New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] Support `assert_type` #15194

Open

InSyncWithFoo wants to merge 3 commits into astral-sh:main from InSyncWithFoo:rk-assert-type

+422 −38

Contributor

InSyncWithFoo commented Dec 30, 2024

Summary

Test Plan

Markdown tests and unit tests.

InSyncWithFoo requested review from carljm, MichaReiser, AlexWaygood and sharkdp as code owners

December 30, 2024 03:53

Contributor

github-actions bot commented Dec 30, 2024 •

edited

Loading

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Contributor Author

InSyncWithFoo commented Dec 30, 2024

This is largely a proof-of-concept. is_equals_to() is not a thing in the specification, and I'm quite sure its name is not the best.

MichaReiser added the red-knot label

sharkdp reviewed

View reviewed changes

Contributor

sharkdp left a comment

Thank you very much for working on this. I added a few initial review comments.

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved

crates/red_knot_python_semantic/resources/mdtest/directives/assert_type.md Outdated Show resolved Hide resolved

crates/red_knot_python_semantic/resources/mdtest/directives/assert_type.md Outdated Show resolved Hide resolved

crates/red_knot_python_semantic/resources/mdtest/directives/assert_type.md Show resolved Hide resolved

crates/red_knot_python_semantic/resources/mdtest/directives/assert_type.md Show resolved Hide resolved

crates/red_knot_python_semantic/resources/mdtest/directives/assert_type.md Outdated Show resolved Hide resolved

MichaReiser reviewed

View reviewed changes

crates/red_knot_python_semantic/src/types/diagnostic.rs Outdated Show resolved Hide resolved

InSyncWithFoo force-pushed the rk-assert-type branch from 3234f80 to 08fd1a5 Compare

January 3, 2025 20:53

carljm reviewed

View reviewed changes

Contributor

carljm left a comment

This looks good, thank you for working on it! I think if we rebase on top of #15103 we can address some of the limitations and get it ready to land.

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved

InSyncWithFoo force-pushed the rk-assert-type branch from 08fd1a5 to 7bb9545 Compare

January 8, 2025 09:24

MichaReiser reviewed

View reviewed changes

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved

MichaReiser reviewed

View reviewed changes

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved

MichaReiser reviewed

View reviewed changes

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved

sharkdp mentioned this pull request

[red-knot] knot_extensions Python API #15103

Merged

7 tasks

InSyncWithFoo force-pushed the rk-assert-type branch from a90a8fd to bf4957f Compare

January 8, 2025 12:32

carljm reviewed

View reviewed changes

crates/red_knot_python_semantic/resources/mdtest/directives/assert_type.md Outdated Show resolved Hide resolved

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved

InSyncWithFoo force-pushed the rk-assert-type branch from d6fa64f to b5d8b8f Compare

January 9, 2025 22:14

carljm reviewed

View reviewed changes

Contributor

carljm left a comment

Looks great, thank you! A few nits here and there, but basically this looks just right.

crates/red_knot_python_semantic/resources/mdtest/directives/assert_type.md Outdated Show resolved Hide resolved

crates/red_knot_python_semantic/resources/mdtest/directives/assert_type.md Outdated Show resolved Hide resolved

crates/red_knot_python_semantic/resources/mdtest/directives/assert_type.md Show resolved Hide resolved

crates/red_knot_python_semantic/resources/mdtest/directives/assert_type.md Show resolved Hide resolved

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved

crates/red_knot_python_semantic/src/types.rs Show resolved Hide resolved

crates/red_knot_python_semantic/src/types.rs Show resolved Hide resolved

crates/red_knot_python_semantic/src/types.rs Show resolved Hide resolved

crates/red_knot_python_semantic/src/types/infer.rs Outdated Show resolved Hide resolved

AlexWaygood reviewed

View reviewed changes

Member

AlexWaygood left a comment

You need to merge/rebase and fix some compilation failures now that #15386 has landed :-)

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved


          [red-knot] Support assert_type

13ace5b

InSyncWithFoo force-pushed the rk-assert-type branch from 5d6ab96 to 13ace5b Compare

January 10, 2025 12:36

InSyncWithFoo added 2 commits

January 10, 2025 12:48


          Per review

e9b6f8d

Fix

050b832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels